Skip to content

animation for location - #5213

Closed
pilunte23 wants to merge 4 commits into
halogenandtoast:mainfrom
pilunte23:feature/location
Closed

animation for location#5213
pilunte23 wants to merge 4 commits into
halogenandtoast:mainfrom
pilunte23:feature/location

Conversation

@pilunte23

Copy link
Copy Markdown

This branch adds a cinematic preview when a location card is flipped or revealed. Instead of showing the full card, the game extracts the illustration area, enlarges it, and displays it briefly with a dynamic glow inspired by the encounter deck revelation effect.

@halogenandtoast

Copy link
Copy Markdown
Owner

Thank you for your contribution @pilunte23

I checked this feature out, but unfortunately I won't be merging this in. Since you spent your time and effort on this, I wanted to provide some insight into my reasoning.

Firstly, I acknowledge that this change attempts to improve the immersion of moving around the mythos by highlighting the art of the locations. On paper this sounds great, but in implementation I have the following issues:

  1. If the art is low quality the result is jarring. I don't know if I will always have access to good quality card scans for cards.
  2. Moving around is something that happens a lot, and granted this only happens on reveal it still delays visual feedback and interaction substantially.
  3. If for some reason the card art is displayed on the bottom of the card instead (see the cosmic emissary for an example of a frame being flipped), I have added maintenance and implementation work to do to support it.

Now as you mentioned this was inspired by the Encounter Card effect. But the Encounter Card effect exists because of original shortcomings in the system. When you drew a card in some situation it would not be visible (or even known) before you needed to respond to it. This made interactions confusing and at the time I did not have a good way of showing this treachery/enemy in the UI as a regular card so I opted for the now present encounter card effect. It's a bit over the top maybe, but it handles a key interaction point, to make you aware of the card and what it does. We do not get the same benefit from highlighting the card art.

Since every new effect or design decision I make is something I have to maintain moving forward I am going to pass on this particular change. I hope that doesn't discourage you from making future contributions. I think all contributions, even ones I don't merge, are important. They help me get more insight into the types of things the community might want me to focus on or improve on.

@github-project-automation github-project-automation Bot moved this from Todo to Done in Arkham Issues Jul 21, 2026
@pilunte23

Copy link
Copy Markdown
Author

Regarding PR, I can understand; the card resolution might be of average quality, so the overall look isn't great.

My suggestion was primarily to try and highlight the illustrations, which are too easily overlooked.
I completely understand that this can disrupt the flow (perhaps by adding an option to enable or disable it in the settings).
But I understand that the overall quality isn't high enough anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants